Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oven-media-engine: init at 0.10.4 #93013

Merged
merged 1 commit into from Jul 17, 2020
Merged

oven-media-engine: init at 0.10.4 #93013

merged 1 commit into from Jul 17, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Jul 12, 2020

Motivation for this change

Application for ingesting RTMP and outputting other video feeds over e.g. WebRTC

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb lukegb force-pushed the oven-media-engine branch 4 times, most recently from 8a0e0da to 4d0f2f0 Compare July 12, 2020 16:59
@lukegb
Copy link
Contributor Author

lukegb commented Jul 12, 2020

@ofborg eval
@ofborg build oven-media-engine

Profpatsch
Profpatsch approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@Profpatsch Profpatsch merged commit 5ecf942 into NixOS:master Jul 17, 2020
@lukegb lukegb deleted the oven-media-engine branch December 5, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @Profpatsch