[Gecko Bug 1652155] Fix document check in Document::TopLayerPop. #24573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Top layer / fullscreen should work in shadow dom. This check is off compared to literally every other fullscreen check. The test is pretty gross, but not my fault, see the comment in there :) Differential Revision: https://phabricator.services.mozilla.com/D83198 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1652155 gecko-commit: 0ed90c257ebde84e9503203b820f2863292fb650 gecko-integration-branch: autoland gecko-reviewers: edgar
wpt-pr-bot
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top layer / fullscreen should work in shadow dom. This check is off
compared to literally every other fullscreen check.
The test is pretty gross, but not my fault, see the comment in there :)
Differential Revision: https://phabricator.services.mozilla.com/D83198
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1652155
gecko-commit: 0ed90c257ebde84e9503203b820f2863292fb650
gecko-integration-branch: autoland
gecko-reviewers: edgar