Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: 0.54.2 → 0.55.0 #93011

Merged
merged 2 commits into from Aug 4, 2020
Merged

meson: 0.54.2 → 0.55.0 #93011

merged 2 commits into from Aug 4, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jul 12, 2020

Motivation for this change

https://mesonbuild.com/Release-notes-for-0-55-0.html
https://github.com/mesonbuild/meson/releases/tag/0.55.0
mesonbuild/meson@0.54.2...0.55.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • built systemd as a test
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Jul 12, 2020
10 tasks
@jtojnar
Copy link
Contributor Author

jtojnar commented Jul 12, 2020

@Ericson2314
Copy link
Member

@jtojnar true. There might be environmental variables for some of them, though.

@FRidh FRidh added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jul 26, 2020
@FRidh FRidh added this to the 20.09 milestone Jul 26, 2020
@FRidh
Copy link
Member

FRidh commented Jul 31, 2020

status?

1 similar comment
@FRidh
Copy link
Member

FRidh commented Jul 31, 2020

status?

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 3, 2020

I am not sure about the extent of the breakage. Could we make a hydra jobset for this branch running release-cross.nix? Or do we just merge this to staging and hope for the best?

@Ericson2314
Copy link
Member

I would just merge and hope for the best. We can make the cross file unconditionally contain stuff like

qmake = '${stdenv.cc.hostPrefix}qmake'

which I think will work.

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 3, 2020

Here is the commit in question: mesonbuild/meson@245d659

Here is the list of known dependencies: https://github.com/mesonbuild/meson/blob/24227a95531b21a04bf2514a5b8f61ae29d47043/mesonbuild/dependencies/__init__.py#L41-L89

We care about those that use/extend ConfigToolDependency class, which is quite a few. Maybe we could find all *-config programs on PATH and add them to cross file.

@Ericson2314
Copy link
Member

because config-tools are such a pain, I bet we're having trouble with many of them anyways, so I would deal with it on an as-needed basis.

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 4, 2020

Merging then.

@jtojnar jtojnar merged commit 5b543ef into NixOS:staging Aug 4, 2020
@jtojnar jtojnar deleted the meson-0.55.0 branch August 4, 2020 02:04
@Ericson2314
Copy link
Member

Just ping me liberally if things do fail! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants