-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A rough implementation of FFT #2637
Conversation
using base::FloorLog2; | ||
|
||
// This class computes Fourier[{...}, FourierParameters -> {1, -1}] in | ||
// Mathematica notation. (The "signal processing" Fourier transform.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge the sentences: notation (the "signal processing" Fourier transform).
// in C++, Dr. Dobbs, 2007. | ||
|
||
template<int array_size_, int chunk_size_ = array_size_> | ||
class DanielsonLánczos { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class could use a comment (and maybe a citation of Some improvements in practical Fourier analysis and their application to X-ray scattering from liquids).
Shouldn’t we have the names of Cooley and Tukey somewhere as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added stuff to the bibliography. Cooley-Tukey (🆒🦃) is for any length (with small prime factors). Danielson-Lánczos is for powers of 2.
Will be useful for #2400.