Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ardour: 6.0 -> 6.2 #93014

Closed
wants to merge 1 commit into from
Closed

ardour: 6.0 -> 6.2 #93014

wants to merge 1 commit into from

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jul 12, 2020 •
edited

New release.

Smoke-tested on a non-jack system -- seems OK, but could probably use testing on jack as well :)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from magnetophon July 12, 2020 16:54
@ofborg ofborg bot requested a review from cillianderoiste July 12, 2020 17:02
@yurkobb
Copy link
Contributor

yurkobb commented Jul 14, 2020

Did a basic test with nixpkgs-review pr on jack audio (1.9.14) - creating an audio track, recording, playing back. No issues discovered, jack works.

@magnetophon
Copy link
Member

I also tested some MIDI.
Works great!

@magnetophon
Copy link
Member

I forgot this PR existed, did one myself, and it got merged. #94440
🤷

@magnetophon magnetophon closed this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetophon magnetophon magnetophon approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @yurkobb @magnetophon