ocamlPackages.ounit(2): 2.2.2 → 2.2.3 #93016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build ocamlPackages.batteries ocamlPackages.irmin-unix |
vbgl
reviewed
Jul 17, 2020
| @@ -1,14 +1,14 @@ | |||
| { lib, buildDunePackage, fetchurl, stdlib-shims }: | |||
|
|
|||
| buildDunePackage rec { | |||
| minimumOCamlVersion = "4.02.3"; | |||
| minimumOCamlVersion = "4.04"; | |||
There was a problem hiding this comment.
This change “removes” many packages: nixpkgs-review lists 92 of them. Is it an issue?
There was a problem hiding this comment.
nixpkgs-review interestingly didn't list any for me, did you use any special options or do rev and pr behave differently?
If you think, it's worth it to fix 4.02 and 4.04 OCaml packages that depend on ounit, I'll go through them and add a
doCheck = lib.versionAtLeast ocaml.version ounit.minimumOCamlVersion;I myself really am not sure, it seems kinda sensible, but I guess if we do this for every such increase of minimumOCamlVersion this becomes a huge task?!
|
@GrahamcOfBorg build beluga flow fstar jackline ocamlformat ocaml-top patdiff satysfi vagrant virt-top |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/gildor478/ounit/releases/tag/v2.2.3
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)