Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wormhole-william: init at v1.0.4 #93030

Merged
merged 2 commits into from Jul 20, 2020
Merged

Conversation

psanford
Copy link
Contributor

Motivation for this change

Add package for wormhole-william end-to-end encrypted file transfer tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to nixpkgs! This PR already looks very good.

One small request. Also, could you split up the commit in two, one that adds the package and one (ordered before it) that adds you to maintainers.nix with the following message:

maintainers: add psanford

pkgs/tools/networking/wormhole-william/default.nix Outdated Show resolved Hide resolved
@psanford
Copy link
Contributor Author

Thanks for reviewing @danieldk! I've updated the PR to address your comments.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making the changes, looks good now!

Result of nixpkgs-review pr 93030 1

1 package built:
- wormhole-william

Will merge it if ofborg is also happy.

wormhole-william is an end-to-end encrypted file transfer tool.
It is compatible with Magic Wormhole.
@zowoq zowoq merged commit 8b66a6f into NixOS:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants