New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wormhole-william: init at v1.0.4 #93030
Conversation
8e71521
to
0cb556a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution to nixpkgs! This PR already looks very good.
One small request. Also, could you split up the commit in two, one that adds the package and one (ordered before it) that adds you to maintainers.nix
with the following message:
maintainers: add psanford
0cb556a
to
73c5e26
Compare
Thanks for reviewing @danieldk! I've updated the PR to address your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for making the changes, looks good now!
Result of nixpkgs-review pr 93030
1
1 package built:
- wormhole-william
Will merge it if ofborg is also happy.
wormhole-william is an end-to-end encrypted file transfer tool. It is compatible with Magic Wormhole.
73c5e26
to
3993e22
Compare
Motivation for this change
Add package for
wormhole-william
end-to-end encrypted file transfer tool.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)