Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gtk file chooser set name methods #650

Closed
wants to merge 1 commit into from
Closed

fix gtk file chooser set name methods #650

wants to merge 1 commit into from

Conversation

xzcvczx
Copy link
Contributor

@xzcvczx xzcvczx commented Jul 12, 2020

use set_filename for existing files based on documentation
change set_current_name to use a Glib::ustring rather than a std::string

@xzcvczx xzcvczx mentioned this pull request Jul 12, 2020
Open
@whitequark
Copy link
Contributor

See also #545 and #562--I think this would break some of the desirable behavior. I didn't realize this would lead to crashes though, so I'll take a look at this sooner.

@phkahler phkahler added the Linux label Oct 17, 2020
@phkahler phkahler force-pushed the master branch 2 times, most recently from dfb96de to 3f09eaf Compare November 7, 2020 20:39
@phkahler phkahler mentioned this pull request Nov 24, 2020
Merged
@phkahler
Copy link
Member

Closing because we're going to base changes on one of the other similar PRs.

@phkahler phkahler closed this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xzcvczx @whitequark @phkahler