Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hplip: Remove all python related gcc references #92994

Merged
merged 1 commit into from Jul 12, 2020
Merged

hplip: Remove all python related gcc references #92994

merged 1 commit into from Jul 12, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jul 12, 2020 •
edited

Motivation for this change

Even with #89265 merged, python3.7's sitePackages was hardcoded, and now when python3.8 is the default, gcc references were back again.

Things done

Switched to using python3Packages.python.sitePackages instead of the hard coded python3.7's sitePackages path.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
hplip: Remove all python related gcc references
359f234 
Use in stripDebugList python sitePackages directory used by the build,
and don't hard code python3.7's sitePackages path.
@doronbehar doronbehar requested a review from ttuegel July 12, 2020 11:28
@dasj19
Copy link
Contributor

dasj19 commented Jul 12, 2020

It builds in a test environment: nix-shell -p nixpkgs-review --run "nixpkgs-review pr 92994"

@ttuegel ttuegel merged commit 1689386 into NixOS:master Jul 12, 2020
@doronbehar
Copy link
Contributor Author

Thank you.

@doronbehar doronbehar deleted the hplip-gcc-references branch March 2, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @dasj19 @ttuegel