Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coc-metals vim plugin #92993

Closed
wants to merge 1 commit into from
Closed

Update coc-metals vim plugin #92993

wants to merge 1 commit into from

Conversation

gvolpe
Copy link
Member

@gvolpe gvolpe commented Jul 12, 2020

Motivation for this change

The existing coc-metals plugin is quite outdated (v0.8.3). It now lives in a different repository. Also, the nodePackages.coc-metals was updated to the latest v0.9.0 but this plugin wasn't, leaving it in an inconsistent state.

As defined in https://raw.githubusercontent.com/NixOS/nixpkgs/master/pkgs/development/node-packages/node-packages.nix

coc-metals = nodeEnv.buildNodePackage {
    name = "coc-metals";
    packageName = "coc-metals";
    version = "0.9.0";
    src = fetchurl {
      url = "https://registry.npmjs.org/coc-metals/-/coc-metals-0.9.0.tgz";
      sha512 = "rQPCK+x+/Aij/YqjGTIS5c5WA3dPba2RwubGouXSRkl8+F1I4NyAXiXtHAx2V4W1LYvmjd990i6Dtzr3JLx+5A==";
    };
Things done

The existing update.py doesn't work for me, as reported in #91656 (comment) and #91339 (comment) so I manually updated generated.nix with the necessary information and updated the name of the plugin in vim-plugin-names (hope that's enough?).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gvolpe gvolpe requested a review from jonringer as a code owner July 12, 2020 11:13
@gvolpe gvolpe mentioned this pull request Jul 12, 2020
Merged
10 tasks
@colemickens
Copy link
Member

colemickens commented Jul 12, 2020 •
edited

Continuing the discussion from here: #91656 (comment)

I did the following on this branch: https://github.com/colemickens/nixpkgs/commits/vim-coc-metal

  • manually remove coc-metal on the old owner (from both generated.nix and vim-plugin-names)
  • ./update.py --add scalameta/coc-metals

For reference:

> ./update.py --add scalameta/coc-metals
598 plugins were checked
updated generated.nix
committing to nixpkgs "vimPlugins: update"
prefetch scalameta/coc-metals
unpacking...
[0.2 MiB DL]
path is '/nix/store/jcaikf5ys36ffbblwbslgm9iil557s7h-630450a7cd1e777ddf1392e672838de2e2965b7c.tar.gz'
599 plugins were checked
updated generated.nix
prefetch scalameta/coc-metals
unpacking...
[0.2 MiB DL]
path is '/nix/store/jcaikf5ys36ffbblwbslgm9iil557s7h-630450a7cd1e777ddf1392e672838de2e2965b7c.tar.gz'
committing to nixpkgs "vimPlugins.coc-metals: init at 2020-07-09"

@gvolpe
Copy link
Member Author

gvolpe commented Jul 13, 2020

Hey @colemickens , thanks a lot for following up on this!

I googled my problem and every answer out there seems to suggest it's a firewall issue on my side but I'm not really sure since I have my firewall completely disabled (networking.firewall.enable = false;).

I made a screencast: https://asciinema.org/a/RCfANXgfT0Pif6lf1J6dOz76a (any hints very much appreciated).

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/getting-no-route-to-host-with-disabled-firewall-on-nixos/8127/1

@stale
Copy link

stale bot commented Apr 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 7, 2021
@gvolpe gvolpe closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gvolpe @colemickens @nixos-discourse @ryantm