Streams: Update queuing strategies to match standard #24577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 13, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2104815
branch
from
a5dd4e8
to
7687a72
Compare
Update the IDL for ByteLengthQueuingStrategy and CountQueuingStrategy to match the standard. The most noticeable semantic difference is that incorrect calls like `new CountQueuingStrategy(10)`, which previously silently gave you the default highWaterMark, will now throw an exception. Also cache the "size" function on the global object. Add a test that iframes have a different "size" function, since they have a different global object. Change-Id: I9b6763944c0abc278451c28a4fcf615f624e1fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104815 Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#788474}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2104815
branch
from
7687a72
to
22557b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the IDL for ByteLengthQueuingStrategy and CountQueuingStrategy
to match the standard.
The most noticeable semantic difference is that incorrect calls like
new CountQueuingStrategy(10), which previously silently gaveyou the default highWaterMark, will now throw an exception.
Also cache the "size" function on the global object. Add a test that
iframes have a different "size" function, since they have a different
global object.
Change-Id: I9b6763944c0abc278451c28a4fcf615f624e1fdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104815
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788474}