Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake doesn't check for presence of yaml-cpp #140

Closed
tdaede opened this issue Jul 10, 2020 · 3 comments · Fixed by #279
Closed

cmake doesn't check for presence of yaml-cpp #140

tdaede opened this issue Jul 10, 2020 · 3 comments · Fixed by #279
Assignees
@kench
Labels
build Build system and infrastructure

Comments

@tdaede
Copy link

tdaede commented Jul 10, 2020

No description provided.

@grevaillot
Copy link

grevaillot commented Jul 10, 2020 •
edited

+1 - debian/ubuntu build instructions are up to date but not following them make build fails as check is not done :)

In file included from ~/tools/scopehal-cmake/lib/scopehal/scopehal.cpp:35:
~/tools/scopehal-cmake/lib/scopehal/scopehal.h:47:10: fatal error: yaml-cpp/yaml.h: No such file or directory
   47 | #include <yaml-cpp/yaml.h>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [lib/scopehal/CMakeFiles/scopehal.dir/build.make:76: lib/scopehal/CMakeFiles/scopehal.dir/scopehal.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:316: lib/scopehal/CMakeFiles/scopehal.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
zsh: exit 2     make

@azonenberg azonenberg transferred this issue from azonenberg/scopehal-cmake Jul 13, 2020
@azonenberg
Copy link
Collaborator

@tarunik want to work on this one when you're finished with the static analysis stuff?

@azonenberg azonenberg added the build Build system and infrastructure label Oct 11, 2020
tarunik added a commit that referenced this issue Nov 6, 2020
@tarunik
Add detection for yaml-cpp, fixes #140
56099d6
@tarunik
Copy link
Collaborator

tarunik commented Nov 6, 2020

This is being fixed by pulling in the FindYaml.cmake from https://github.com/lbaehren/CMakeModules/blob/master/FindYaml.cmake

tarunik added a commit that referenced this issue Nov 6, 2020
@tarunik
Remove errant find_package call from the fix for #140
755ec5b
@azonenberg azonenberg linked a pull request Nov 6, 2020 that will close this issue
Add detection for yaml-cpp, fixes #140 #279
Merged
azonenberg added a commit that referenced this issue Nov 6, 2020
@azonenberg
Merge pull request #279 from azonenberg/fix-yaml
2d2c6ee 
Add detection for yaml-cpp, fixes #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kench kench

Labels
build Build system and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add detection for yaml-cpp, fixes #140 ngscopeclient/scopehal-apps
5 participants
@kench @grevaillot @azonenberg @tdaede @tarunik