[appmanifest] add basic tests for start_url #24574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
Jul 13, 2020
christianliebel
force-pushed
the
appmanifest/start_url
branch
from
57259c6
to
90749f4
Compare
|
Hmm... linter failed but it doesn't seem to provide any info (or I can't figure out the UI to get info). We might need lint locally. |
It does, but it's unfortunately still a pain to get to until we land support for github actions 'output'. But if you follow 'View task in Taskcluster' and then 'View Live Log' (a complete pain, we know), you get: Interestingly, that's also not a particularly useful error message from the linter. Clearly doing that is wrong, but it doesn't explain why or importantly what to use instead. |
I had a feeling that was the problem :) Yeah, some guidance there would be really helpful specially for these manual tests. |
stephenmcgruer
added a commit
that referenced
this pull request
Jul 23, 2020
I've sent #24720 for this |
Hexcles
pushed a commit
that referenced
this pull request
Jul 27, 2020
See #24574 (comment) And update link in docs.
|
Thanks @stephenmcgruer! @christianliebel is going to take a look and we should hopefully have a fix next week (@christianliebel we can try to work on these together next Monday if the changes look tricky). |
|
@marcoscaceres Fixed! Thank you, @stephenmcgruer. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 1, 2020
….test lint rule, a=testonly Automatic update from web-platform-tests Document how to address the web-platform.test lint rule (#24720) See web-platform-tests/wpt#24574 (comment) And update link in docs. -- wpt-commits: 2afcc84e7da41d6763dca88c48a101f8c85d4ee9 wpt-pr: 24720
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Aug 1, 2020
….test lint rule, a=testonly Automatic update from web-platform-tests Document how to address the web-platform.test lint rule (#24720) See web-platform-tests/wpt#24574 (comment) And update link in docs. -- wpt-commits: 2afcc84e7da41d6763dca88c48a101f8c85d4ee9 wpt-pr: 24720
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Aug 3, 2020
….test lint rule, a=testonly Automatic update from web-platform-tests Document how to address the web-platform.test lint rule (#24720) See web-platform-tests/wpt#24574 (comment) And update link in docs. -- wpt-commits: 2afcc84e7da41d6763dca88c48a101f8c85d4ee9 wpt-pr: 24720 UltraBlame original commit: 8404a8353d59148f49c8edc947c9d384bb1def2f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Aug 3, 2020
….test lint rule, a=testonly Automatic update from web-platform-tests Document how to address the web-platform.test lint rule (#24720) See web-platform-tests/wpt#24574 (comment) And update link in docs. -- wpt-commits: 2afcc84e7da41d6763dca88c48a101f8c85d4ee9 wpt-pr: 24720 UltraBlame original commit: 8404a8353d59148f49c8edc947c9d384bb1def2f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Aug 3, 2020
….test lint rule, a=testonly Automatic update from web-platform-tests Document how to address the web-platform.test lint rule (#24720) See web-platform-tests/wpt#24574 (comment) And update link in docs. -- wpt-commits: 2afcc84e7da41d6763dca88c48a101f8c85d4ee9 wpt-pr: 24720 UltraBlame original commit: 8404a8353d59148f49c8edc947c9d384bb1def2f
marcoscaceres
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.