Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diskonaut: 0.3.0 -> 0.9.0 #93018

Merged
merged 1 commit into from Jul 12, 2020
Merged

diskonaut: 0.3.0 -> 0.9.0 #93018

merged 1 commit into from Jul 12, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Jul 12, 2020

Bump diskonaut from 0.3.0 to 0.9.0

Motivation for this change

Diskonaut now measures file sizes consistently and tests can be run
without modification

discussion: imsnif/diskonaut#50
tracking issue: imsnif/diskonaut#56
implementation: imsnif/diskonaut#66

Things done
  • remove special handling for checkPhase
  • tested on F2FS and EXT4

remove special handling for checkPhase
Diskonaut now measures file sizes consistently and tests can be run
without modification

discussion: imsnif/diskonaut#50
implementation: imsnif/diskonaut#66
@dasj19
Copy link
Contributor

dasj19 commented Jul 12, 2020

Tested with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93018" and works fine

@Ma27 Ma27 merged commit 28f1c45 into NixOS:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants