Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ffts as a submodule #144

Closed
whitequark opened this issue Jul 13, 2020 · 2 comments
Closed

Add ffts as a submodule #144

whitequark opened this issue Jul 13, 2020 · 2 comments
Labels
build Build system and infrastructure

Comments

@whitequark
Copy link
Contributor

This is annoying to do manually (I distinctly remember having to screw with it to get it to work at least twice for scopehal), and might fix #139.
@azonenberg azonenberg added the build Build system and infrastructure label Oct 11, 2020
@karlp
Copy link

karlp commented Sep 20, 2022 •
edited

Is there any reason not to just use fftw? it's well packaged and widely available, ffts hasn't had any commits in 6 years and it's website is offline? (I'm guessing a very important reason is fftw being gpl, so yeah, very much submodule this please!)

@azonenberg
Copy link
Collaborator

Yes, the license incompatibility is the primary reason we didn't use FFTW. There is an extreme lack of permissively licensed FFT libraries and it was the best option available at the time.

We are actually in the process of moving away from FFTS in favor of vkFFT (ngscopeclient/scopehal#660) so this ticket should have been closed as wontfix.

Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Build system and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whitequark @karlp @azonenberg