Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitolite: provision data directory only before service begins #93001

Merged
merged 1 commit into from Jul 14, 2020
Merged

nixos/gitolite: provision data directory only before service begins #93001

merged 1 commit into from Jul 14, 2020

Conversation

aanderse
Copy link
Member

Motivation for this change

This PR aims to resolve #92473 by utilizing StateDirectory to provision directories after gitolite has started/been initialized.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Jul 12, 2020 •
edited

@GrahamcOfBorg test gitolite gitolite-fcgiwrap

tokudan
tokudan approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@tokudan tokudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good solution to me :)
I tested this change on 20.03 and it works well. Thanks!

@flokli flokli merged commit e99389a into NixOS:master Jul 14, 2020
@aanderse aanderse deleted the gitolite branch July 14, 2020 18:41
@flokli
Copy link
Contributor

flokli commented Jul 14, 2020

This shouldn't break any existing installs, the fact that dataDir isn't provisioned any more only covers new installations (and it's documented in the description), so this is fine :-)

@aanderse aanderse mentioned this pull request Jun 5, 2021
Merged
11 tasks
@aanderse aanderse mentioned this pull request Dec 4, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@tokudan tokudan tokudan approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitolite creates directories through systemd.tmpfiles.rules
3 participants
@aanderse @flokli @tokudan