Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log version and module information to ERROR #2642

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jul 12, 2020

Some users (I'm looking at you, @lpgagnon) have been known to give us the ERROR file and it's a bit embarrassing that we cannot do anything with it because we don't have enough information there to decode the stack.

@eggrobin
Copy link
Member

eggrobin commented Jul 12, 2020

This means that we would systematically create the ERROR and WARNING files even if we never log at those severities, which makes me sad.

On the other hand we have quite a bit of log spam at ERROR at the moment because of the Reached maximum step count business, so that the existence of the files is not a very useful signal; we can revisit this (by adding this information in the log file header on the glog side, instead of adding it as log lines) once we have dealt with that log spam.

@eggrobin eggrobin added the LGTM label Jul 12, 2020
@pleroy pleroy merged commit 7d7694d into mockingbirdnest:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants