Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i2p: 0.9.42 -> 0.9.47 #93022

Merged
merged 1 commit into from Sep 6, 2020
Merged

i2p: 0.9.42 -> 0.9.47 #93022

merged 1 commit into from Sep 6, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jul 12, 2020 •
edited

Motivation for this change

Version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from joelmo July 12, 2020 20:50
@mkg20001 mkg20001 mentioned this pull request Aug 22, 2020
Closed
@mkg20001
Copy link
Member

I've merged this to my private nixpkgs and seems to work fine so far

Also 0.9.47 came out meanwhile, so maybe we could do both at once?

@prusnak
Copy link
Member Author

prusnak commented Aug 28, 2020

Updated PR to include version update to 0.9.47

@prusnak prusnak changed the title i2p: 0.9.42 -> 0.9.46 i2p: 0.9.42 -> 0.9.47 Aug 28, 2020
@worldofpeace worldofpeace merged commit 125ac74 into NixOS:master Sep 6, 2020
@prusnak prusnak deleted the i2p branch September 6, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelmo joelmo Awaiting requested review from joelmo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @mkg20001 @worldofpeace