Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mozprocess to 1.2.0 #24578

Merged
merged 14 commits into from Jul 30, 2020
Merged

Conversation

pyup-bot
Copy link
Contributor

This PR updates mozprocess from 1.0.0 to 1.2.0.

The bot wasn't able to find a changelog for this release. Got an idea?

Links

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Jul 13, 2020
@LukeZielinski
Copy link
Contributor

Over to @jgraham -- looks like this needs some code changes inside wptrunner. WDYT?

@jgraham
Copy link
Contributor

jgraham commented Jul 13, 2020

I strongly suspect it actually depends on getting an updated version of some other mozbase package; we are running against the master rev in gecko infra so this kind of thing shouldn't require changes in our code.

@Hexcles Hexcles closed this Jul 20, 2020
@Hexcles Hexcles reopened this Jul 20, 2020
@Hexcles Hexcles closed this Jul 28, 2020
@Hexcles Hexcles reopened this Jul 28, 2020
@stephenmcgruer
Copy link
Contributor

So if I'm reading right, the main error is:

ERROR Traceback (most recent call last):
  File "/home/test/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py", line 222, in init
    self.browser.start(group_metadata=group_metadata, **self.browser_settings)
  File "/home/test/web-platform-tests/tools/wptrunner/wptrunner/browsers/chrome.py", line 123, in start
    self.server.start(block=False)
  File "/home/test/web-platform-tests/tools/wptrunner/wptrunner/webdriver_server.py", line 51, in start
    self._run(block)
  File "/home/test/web-platform-tests/tools/wptrunner/wptrunner/webdriver_server.py", line 61, in _run
    storeOutput=False)
  File "/home/test/web-platform-tests/_venv3/lib/python3.6/site-packages/mozprocess/processhandler.py", line 1238, in __init__
    stdout = sys.stdout.buffer
AttributeError: 'LoggingWrapper' object has no attribute 'buffer'

sys.stdout is overwritten (!!) in mozlog/capture.py inside any CaptureIO scope, to be a LoggingWrapper, which is an io.BytesIO subclass with little extra stuff as far as I can tell. Now, as far as I know, io.BytesIO doesn't have a buffer attribute, so that's a bit confusing.

@jgraham
Copy link
Contributor

jgraham commented Jul 28, 2020

It's a Python 3 issue; Python 3 gives sys.stdout a buffer attribute which makes wrapping it excitingly error-prone since it doesn't behave like a normal file. I've fixed the bug in mozilla-central but a new mozlog release is needed. Maybe tomorrow, or if you're reading this and it's later than tomorrow please ping me to get it done.

@stephenmcgruer
Copy link
Contributor

I've fixed the bug in mozilla-central but a new mozlog release is needed.

Awesome, thanks jgraham! Be assured I will chase it up ;)

@stephenmcgruer
Copy link
Contributor

mozlog has been updated to 6.1, retrying this.

@stephenmcgruer
Copy link
Contributor

Community-TC now passes (woo!). Azure Pipeline failures are various existing issues I believe (I'm currently working on investigating those elsewhere), so merging.

@stephenmcgruer stephenmcgruer merged commit b312abc into master Jul 30, 2020
@stephenmcgruer stephenmcgruer deleted the pyup-update-mozprocess-1.0.0-to-1.2.0 branch July 30, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants