Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amd-blis: init at 2.2 #93052

Merged
merged 1 commit into from Aug 8, 2020
Merged

amd-blis: init at 2.2 #93052

merged 1 commit into from Aug 8, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 13, 2020 •
edited

Motivation for this change

Add BLIS optimized for AMD Zen CPUs.

We compile specifically for Zen:

  • Zen/Zen2 are not included in the x86_64 or amd64 configurations.
  • Including them breaks AMD BLIS in other places, since some functions
    have Zen-specific definitions that fail on other platforms.

Non-Zen CI runners will succeed when they are Haswell or later, since
a Haswell kernel is compiled as a dependency.

Tested: building numpy against AMD BLIS.

This is a resubmission of #92981.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk marked this pull request as ready for review July 13, 2020 10:36
@danieldk danieldk requested a review from bhipple July 13, 2020 10:37
@danieldk
amd-blis: init at 2.2
4fbe92d 
We compile specifically for Zen:

- Zen/Zen2 are not included in the x86_64 or amd64 configurations.
- Including them breaks AMD BLIS in other places, since some functions
  have Zen-specific definitions that fail on other platforms.

Non-Zen CI runners will succeed when they are Haswell or later, since
a Haswell kernel is compiled as a dependency.
@bhipple
Copy link
Contributor

bhipple commented Jul 17, 2020

I'm on vacation for a while and haven't had time to review this, but perhaps @matthewbauer could take a look.

@danieldk
Copy link
Contributor Author

I'm on vacation for a while and haven't had time to review this, but perhaps @matthewbauer could take a look.

Enjoy your vacation! 🌴

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/251

@danieldk
Copy link
Contributor Author

danieldk commented Aug 8, 2020

Thanks for the review!

@danieldk danieldk merged commit 57d4c67 into NixOS:master Aug 8, 2020
@danieldk danieldk deleted the amd-blis-zen-only branch August 8, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @bhipple @nixos-discourse