write next state to vcd instead of curr state, since state is written just prior to commit #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… just prior to commit Fixes amaranth-lang#429
|
So actually a better fix would be to accumulate |
|
Would you be willing to merge this fix while you finish off the better fix, since this one is pretty simple? I'm not 100% sure, but I think #429 is blocking several people in Libre-SOC to some extent. |
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 81.72% 81.71% -0.01%
==========================================
Files 40 40
Lines 6100 6099 -1
Branches 1243 1242 -1
==========================================
- Hits 4985 4984 -1
Misses 935 935
Partials 180 180
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429
I tested it and it seems to work!
@whitequark You can add a regression test later if you want.