Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mono5: 5.20.1.27 -> 5.20.1.34 #93043

Merged
merged 1 commit into from May 13, 2021
Merged

mono5: 5.20.1.27 -> 5.20.1.34 #93043

merged 1 commit into from May 13, 2021

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Jul 13, 2020 •
edited

Motivation for this change

Version bump for version 5 of mono.

Release changelog notes:
mono5: https://www.mono-project.com/docs/about-mono/releases/5.20.0/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @thoughtpolice @obadz @vrthra

@dasj19 dasj19 mentioned this pull request Jul 13, 2020
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-dotnet-mono-overcoming-you-must-add-a-reference-to-assembly-netstandard/8190/5

@dasj19
Copy link
Contributor Author

dasj19 commented Aug 10, 2020

CC'ing mono maintainers for review: @thoughtpolice @obadz @vrthra
Thanks.

@DamienCassou
Copy link
Contributor

Result of nixpkgs-review pr 93043 1

1 package marked as broken and skipped:
- scallion
26 packages failed to build:
- dotnetPackages.ExtCore
- dotnetPackages.FSharpAutoComplete
- dotnetPackages.FSharpCompilerService
- foundationdb (foundationdb61)
- foundationdb51
- foundationdb52
- foundationdb60
- fsharp41
- gdata-sharp
- monodevelop
- openraPackages.mods.mw
- python27Packages.foundationdb51
- python27Packages.foundationdb52
- python27Packages.foundationdb60
- python27Packages.foundationdb61
- python37Packages.foundationdb51
- python37Packages.foundationdb52
- python37Packages.foundationdb60
- python37Packages.foundationdb61
- python38Packages.foundationdb51
- python38Packages.foundationdb52
- python38Packages.foundationdb60
- python38Packages.foundationdb61
- python38Packages.pythonnet
- steam-run-native
- ue4
126 packages built:
- avrdudess
- bless
- boogie (dotnetPackages.Boogie)
- ckan
- convchain
- dafny (dotnetPackages.Dafny)
- dbus-sharp-1_0
- dbus-sharp-glib-1_0
- dbus-sharp-glib-2_0
- dotnetPackages.Autofac
- dotnetPackages.Deedle
- dotnetPackages.ExcelDna
- dotnetPackages.ExcelDnaRegistration
- dotnetPackages.FSharpCompilerCodeDom
- dotnetPackages.FSharpCompilerTools
- dotnetPackages.FSharpCore302
- dotnetPackages.FSharpCore3125
- dotnetPackages.FSharpCore4001
- dotnetPackages.FSharpCore4117
- dotnetPackages.FSharpData
- dotnetPackages.FSharpData225
- dotnetPackages.FSharpDataSQLProvider
- dotnetPackages.FSharpFormatting
- dotnetPackages.Fake
- dotnetPackages.Fantomas
- dotnetPackages.FsCheck
- dotnetPackages.FsCheck262
- dotnetPackages.FsCheckNunit
- dotnetPackages.FsLexYacc
- dotnetPackages.FsLexYacc706
- dotnetPackages.FsLexYaccRuntime
- dotnetPackages.FsPickler
- dotnetPackages.FsUnit
- dotnetPackages.FuzzyLogicLibrary
- dotnetPackages.GitVersionTree
- dotnetPackages.MathNetNumerics
- dotnetPackages.MaxMindDb
- dotnetPackages.MaxMindGeoIP2
- dotnetPackages.MicrosoftDiaSymReader
- dotnetPackages.MicrosoftDiaSymReaderPortablePdb
- dotnetPackages.MonoAddins
- dotnetPackages.MonoNat
- dotnetPackages.NDeskOptions
- dotnetPackages.NUnit (dotnetPackages.NUnit2)
- dotnetPackages.NUnit3
- dotnetPackages.NUnit350
- dotnetPackages.NUnitConsole
- dotnetPackages.NUnitRunners
- dotnetPackages.NewtonsoftJson
- dotnetPackages.Nuget
- dotnetPackages.OpenNAT
- dotnetPackages.Paket
- dotnetPackages.Projekt
- dotnetPackages.RestSharp
- dotnetPackages.SharpFont
- dotnetPackages.SharpZipLib
- dotnetPackages.SmartIrc4net
- dotnetPackages.StyleCopMSBuild
- dotnetPackages.StyleCopPlusMSBuild
- dotnetPackages.Suave
- dotnetPackages.SystemCollectionsImmutable
- dotnetPackages.SystemCollectionsImmutable131
- dotnetPackages.SystemReflectionMetadata
- dotnetPackages.SystemValueTuple
- dotnetPackages.UnionArgParser
- dotnetbuildhelpers
- duplicati
- eventstore
- fsharp
- gio-sharp
- gnome-sharp
- gtk-sharp-2_0
- gtk-sharp-3_0
- gtk-sharp-beans
- haskellPackages.clr-bindings
- haskellPackages.clr-host
- haxePackages.hxcs
- hyena
- keepass
- keepass-keeagent
- keepass-keepasshttp
- keepass-keepassrpc
- keepass-otpkeyprov
- kodiPlugins.steam-launcher
- lidarr
- lutris
- midisheetmusic
- mono (mono5)
- mono-addins
- mono6
- msbuild
- notify-sharp
- omnisharp-roslyn
- openra (openraPackages.engines.release)
- openraPackages.engines.bleed
- openraPackages.engines.playtest
- openraPackages.mods.ca
- openraPackages.mods.d2
- openraPackages.mods.dr
- openraPackages.mods.gen
- openraPackages.mods.kknd
- openraPackages.mods.ra2
- openraPackages.mods.raclassic
- openraPackages.mods.rv
- openraPackages.mods.sp
- openraPackages.mods.ss
- openraPackages.mods.ura
- openraPackages.mods.yr
- osu-lazer
- pash
- pdfmod
- pinta
- python-language-server
- python27Packages.pythonnet
- python37Packages.pythonnet
- radarr
- sonarr
- steam
- steam-run
- steamcmd
- supertux-editor
- syntex
- taglib-sharp
- tomboy
- wasabibackend
- wavefunctioncollapse

@DamienCassou
Copy link
Contributor

Thank you for your contribution @dasj19. As you can see from my previous comment, some dependent packages fail to build. Can you please have a look?

@ericdallo
Copy link
Member

Any news here @dasj19 ?

@ericdallo ericdallo self-requested a review September 21, 2020 02:58
@Narice
Copy link
Contributor

Narice commented Nov 2, 2020

mono6 installation works! thank you @dasj19! Btw, you should maybe bump the version of mono6 to 6.12.0.90 ;)
@ericdallo is this mergeable or is something needed for it to be merged? Because a version higher than 6.4.0 is required to start Omnisharp, so this PR is quite important for C# devs.

@SuperSandro2000
Copy link
Member

The mono6 version on master is already newer. Can you please remove that change?

@dasj19 dasj19 changed the title mono5: 5.20.1.27 -> 5.20.1.34, mono6: 6.0.0.313 -> 6.10.0.104 mono5: 5.20.1.27 -> 5.20.1.34 Feb 3, 2021
@dotlambda dotlambda mentioned this pull request May 12, 2021
Closed
dotlambda
dotlambda approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also builds on aarch64-linux.

@dotlambda dotlambda linked an issue May 12, 2021 that may be closed by this pull request
mono is broken on aarch64-linux #115958
Closed
@dotlambda
Copy link
Member

cc @NixOS/nixos-release-managers

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 6920440 into NixOS:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@ericdallo ericdallo Awaiting requested review from ericdallo

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@obadz obadz Awaiting requested review from obadz

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mono is broken on aarch64-linux
7 participants
@dasj19 @nixos-discourse @DamienCassou @ericdallo @Narice @SuperSandro2000 @dotlambda