Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel 3 add fish completions #93062

Merged
merged 3 commits into from Jul 17, 2020
Merged

Bazel 3 add fish completions #93062

merged 3 commits into from Jul 17, 2020

Conversation

Profpatsch
Copy link
Member

fish completions and minor refactor (see commit messages)

cc @kalbasit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch Profpatsch requested a review from avdv July 13, 2020 12:57
lukegb
lukegb approved these changes Jul 13, 2020
View reviewed changes
pkgs/development/tools/build-managers/bazel/bazel_3/default.nix Outdated
install -Dm644 \
./bazel_src/output/bazel-complete.bash \
$out/share/bash-completion/completions/bazel/bazel-complete.bash
install -Dm755 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be 644 as well.

@ofborg ofborg bot requested a review from mboes July 13, 2020 13:27
@Profpatsch Profpatsch force-pushed the bazel-3-add-fish-completions branch from 9b73ebc to 32f9b6c Compare July 15, 2020 09:50
@Profpatsch
bazel: use install for completions
fd2965c 
Preserving existing behavior: the bash completion was not executable,
the zsh completion was; according to lukegb the fish completion does
not have to be executable.
@Profpatsch
bazel: add fish completions
0148565 
bazel 3.3 adds a first version of completions for fish shell.

Tested manually whether fish is able to load the completions.
@Profpatsch Profpatsch force-pushed the bazel-3-add-fish-completions branch from 32f9b6c to 0148565 Compare July 17, 2020 12:43
@Profpatsch
Copy link
Member Author

Darwin failure is unrelated.

@Profpatsch Profpatsch merged commit 595afc2 into NixOS:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@lukegb lukegb lukegb approved these changes

@avdv avdv avdv approved these changes

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Profpatsch @danieldk @lukegb @avdv