TC: don't run print tests for WebKitGTK and Servo #24576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
Hexcles,
jgraham,
LukeZielinski and
stephenmcgruer
…#24576) * print-reftests are currently not supported for this two browsers. So we need to avoid triggering those runs on taskcluster for them to avoid failing the whole run. This fixes: web-platform-tests#24360 and web-platform-tests#24257. * This patch removes the print-reftest suite from the general block and adds a new block for it and for the browsers that support this tests on taskcluster (Chrome and Firefox).
clopez
force-pushed
the
tc_no_run_print_reftest_webkitgtk_servo
branch
from
418a383
to
30a02f1
Compare
jgraham
approved these changes
Jul 13, 2020
I agree. I tried to avoid this duplication. But after spending some time on it, i wasn't able to implement a better solution than duplicating the block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we need to avoid triggering those runs on taskcluster for them to
avoid failing the whole run. This fixes: Missing WebKitGTK runs since June 22 #24360 and Latest Servo run on wpt.fyi is from March 6 #24257.
and adds a new block for it and for the browsers that support this
tests on taskcluster (chrome and firefox).