Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.idris2-vim: init at 2020-05-25 #93021

Merged
merged 1 commit into from Nov 24, 2020
Merged

vimPlugins.idris2-vim: init at 2020-05-25 #93021

merged 1 commit into from Nov 24, 2020

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change

availability of https://github.com/edwinb/idris2-vim

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jorsn July 12, 2020 21:06
@jonringer
Copy link
Contributor

sorry I wasn't able to review the package earlier, do you mind redo'ing the addition steps?

@ikervagyok
Copy link
Contributor Author

@jonringer I hope I haven't messed up the steps, as I thought in this case redoing everything is better then rebasing...

@jonringer
Copy link
Contributor

jonringer commented Aug 17, 2020 •
edited

do you mind running it one more time, one of the packages is failing, but is fixed on master 3 hours ago nvim-treesitter/nvim-treesitter@0b3cd6c

https://github.com/NixOS/nixpkgs/pull/93021
1 package failed to build:
vimPlugins.nvim-treesitter

11 packages built:
vimPlugins.ale vimPlugins.defx-nvim vimPlugins.idris2-vim vimPlugins.lightline-bufferline vimPlugins.lightline-vim vimPlugins.neoformat vimPlugins.neosnippet-snippets vimPlugins.nvim-gdb vimPlugins.tagbar vimPlugins.vim-css-color vimPlugins.vim-graphql

@ikervagyok
Copy link
Contributor Author

@jonringer it's updated again. hope it works now.

@ofborg ofborg bot requested a review from jagajaga October 24, 2020 13:15
@ikervagyok
Copy link
Contributor Author

removed all the updates that get generated, since they lead to conflicts. Only adding idris2-vim.

@ikervagyok
Copy link
Contributor Author

ping @jonringer - can we merge this?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 93021 run on x86_64-linux 1

1 package built:
  • vimPlugins.idris2-vim

jonringer
jonringer approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 93021 1

1 package built:
  • vimPlugins.idris2-vim

@jonringer jonringer merged commit ef052cf into NixOS:master Nov 24, 2020
@jonringer
Copy link
Contributor

ping @jonringer - can we merge this?

yea, I get more notifications than I have time in the day to respond to. Sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jorsn jorsn Awaiting requested review from jorsn

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ikervagyok @jonringer @SuperSandro2000 @ryantm