New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libupnp: 1.12.0 -> 1.14.0 #93048
libupnp: 1.12.0 -> 1.14.0 #93048
Conversation
|
Actually I've noticed |
thanks for the heads up, i'll check and adapt. |
bba35c3
to
3cccf9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
tells me that this breaks three packages that built previously: amule
, amuleDaemon
and gmrender-resurrect
.
Do you have some links about the proper way to deal with those package breaks? Cheers, |
If you have some time to spare, you could have a look at the build log and see if there is anything obvious that needs fixing. It could also be helpful to check out the upstream bug ticker, or if there are any new releases available that might be compatible. If you do not have the spare time right now, you can ping the maintainers of the broken packages here and give them ~a week to respond. They can then fix the issue, or if they don't respond you can mark the packages as broken. |
I concur:
I checked against a more recent master build which render the same results (so i updated that diff). |
#99893 fixes amule and amuleDaemon by bumping the version |
That's because it requires to validate a license for the build, it does not relate to this. |
I looked into that one as well and a PR is already opened to fix |
And there we go, #99899 should fix that last one. |
There has been no new release since 2.3.2 for some years now (around 2016) [1] The most recent master branch for the amule project includes a commit [2] which fixes compilation breakage with the next libupnp version [3]. So this bumps the amule version to the latest commit of that repository. [1] amule-project/amule#219 [2] amule-project/amule@8784480 [3] NixOS#93048
Updated the summary with the other PR references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/ Awesome \m/ Cheers, |
Trying to package gerbera (upnp media server) which requires at least that
dependency version in its build recipe.
sandbox
innix.conf
on non-NixOS linux)nixpkgs-review pr 93048
[1]./result/bin/
)[1] 3 packages broke with this, last one (obs-ndi is in the same state as master, needs a license to build):
Those 3 are fixed with the following PR: