[nativeio] NativeIO: Add setLength #24575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 13, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2257855
branch
3 times, most recently
from
47195bc
to
3348f04
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2257855
branch
3 times, most recently
from
67d8331
to
e0de4b0
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2257855
branch
4 times, most recently
from
0de5d8d
to
dfba3c3
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2257855
branch
2 times, most recently
from
6afbc71
to
3791077
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2257855
branch
from
3791077
to
e45f1bb
Compare
The MacOS sandbox does not allow calling base::File::SetLength() from the renderer directly, see crbug.com/1084565. The call to setLength is therefore routed through the browser process, which likely decreases performance and increases complexity. Another option would be to create a SeatbeltExtensionToken that allows to pierce the sandbox on MacOS for a single file. As this would likely lead to more complex code, we decided that going through the browser process is the better option for now. Bug: 914488 Change-Id: Idc58d804e19751a2e37cfeb5c645f778edf4639c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257855 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#799005}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2257855
branch
from
e45f1bb
to
07f5671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MacOS sandbox does not allow calling base::File::SetLength() from
the renderer directly, see crbug.com/1084565. The call to setLength is
therefore routed through the browser process, which likely decreases
performance and increases complexity. Another option would be to create
a SeatbeltExtensionToken that allows to pierce the sandbox on MacOS for
a single file. As this would likely lead to more complex code, we
decided that going through the browser process is the better option for
now.
Bug: 914488
Change-Id: Idc58d804e19751a2e37cfeb5c645f778edf4639c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257855
Commit-Queue: Richard Stotz <rstz@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799005}