Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions coming from Nixpkgs upgrades #194

Merged
merged 2 commits into from Aug 18, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Aug 18, 2020

Two distinct issues:


The option has been removed.

NixOS/nixpkgs@aebf9a4


Using an removed option, now detected due to stricter checking in the modules system.

@samueldr samueldr added the 4. type: regression Something stopped working label Aug 18, 2020
Recent changes in Nixpkgs makes it more strict.

This is a change that wasn't caught as needed from the migration to
structured options for device infos.
@samueldr samueldr changed the title nixos-disintegration: Remove the disabled showManual option Fix regressions coming from Nixpkgs upgrades Aug 18, 2020
@samueldr samueldr merged commit 406e22e into NixOS:master Aug 18, 2020
@samueldr samueldr deleted the fix/manual-options-regression branch August 18, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: regression Something stopped working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant