Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/awesome: add wrapped awesome to systemPackages #95750

Closed
wants to merge 1 commit into from

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Aug 18, 2020

Motivation for this change

Lets user start awesome in the same way as the display-manager would do,
including luaPaths.
I prefer not using a display manager at all, and instead starting my wm using xinit/startx. However, that breaks my awesome setup as I use some the nixos config to add some lua modules to awesomes search path: these search path additions are only made available for the xsession script. This change makes it possible to started a wrapped awesome with the same lua search paths from startx.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -11,6 +11,9 @@ let
" --search " + (getLuaPath path "share") +
" --search " + (getLuaPath path "lib")
);
awesomeWrapped = (writeScriptBin ".awesome-wrapped" ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally with wrapProgram the wrapper becomes available under the normal name and the original executable is moved to .$exeName-wrapped - the opposite of what you're doing here.

I don't see a reason to keep the non-wrapped awesome around, so to avoid confusion I think it makes sense to use plain awesome as the name for the wrapper and remove the original awesome from systemPackages.

If there's a good reason to keep the original around, you could use a name like awesome-wrapped or something similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Idea was to not break anything. On closer inspection, I wouldn't know what could break though. Your reasoning sounds perfectly reasonable to me, so I will adjust accordingly.

@stale
Copy link

stale bot commented Mar 5, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 5, 2021
@wucke13
Copy link
Contributor Author

wucke13 commented Mar 6, 2021

@GrahamcOfBorg eval

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 6, 2021
@stale
Copy link

stale bot commented Sep 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 3, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 3, 2021
@wucke13 wucke13 force-pushed the awesome branch 3 times, most recently from 0b38813 to 983fdc5 Compare September 11, 2021 11:32
Lets user start awesome in the same way as the display-manager would do,
including luaPaths.
@lucc
Copy link
Contributor

lucc commented Sep 11, 2021

@wucke13 Do you know how I can build this from the command line for testing? I am wondering whether the awesome-client will be available in systemPackages and the manpage can be found.

@wucke13
Copy link
Contributor Author

wucke13 commented Sep 12, 2021

@wucke13 Do you know how I can build this from the command line for testing?

I would use nix-review pr 95750

Or build a virtual machine with a config using the checkout of my repo as nixpkgs.

I am wondering whether the awesome-client will be available in systemPackages and the manpage can be found.

Valid points which I have not thought about

@stale
Copy link

stale bot commented Apr 17, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 17, 2022
@wucke13
Copy link
Contributor Author

wucke13 commented Apr 18, 2022

I don't have interest any more in pursuing this.

@wucke13 wucke13 closed this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants