New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/awesome: add wrapped awesome to systemPackages #95750
Conversation
@@ -11,6 +11,9 @@ let | |||
" --search " + (getLuaPath path "share") + | |||
" --search " + (getLuaPath path "lib") | |||
); | |||
awesomeWrapped = (writeScriptBin ".awesome-wrapped" '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally with wrapProgram
the wrapper becomes available under the normal name and the original executable is moved to .$exeName-wrapped
- the opposite of what you're doing here.
I don't see a reason to keep the non-wrapped awesome
around, so to avoid confusion I think it makes sense to use plain awesome
as the name for the wrapper and remove the original awesome
from systemPackages
.
If there's a good reason to keep the original around, you could use a name like awesome-wrapped
or something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Idea was to not break anything. On closer inspection, I wouldn't know what could break though. Your reasoning sounds perfectly reasonable to me, so I will adjust accordingly.
I marked this as stale due to inactivity. → More info |
@GrahamcOfBorg eval |
I marked this as stale due to inactivity. → More info |
0b38813
to
983fdc5
Compare
Lets user start awesome in the same way as the display-manager would do, including luaPaths.
@wucke13 Do you know how I can build this from the command line for testing? I am wondering whether the |
I would use Or build a virtual machine with a config using the checkout of my repo as nixpkgs.
Valid points which I have not thought about |
I marked this as stale due to inactivity. → More info |
I don't have interest any more in pursuing this. |
Motivation for this change
Lets user start awesome in the same way as the display-manager would do,
including luaPaths.
I prefer not using a display manager at all, and instead starting my wm using
xinit
/startx
. However, that breaks my awesome setup as I use some the nixos config to add some lua modules to awesomes search path: these search path additions are only made available for the xsession script. This change makes it possible to started a wrapped awesome with the same lua search paths from startx.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)