Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discrete-scroll: init at 0.1.1 #95768

Merged
merged 1 commit into from Aug 28, 2020
Merged

discrete-scroll: init at 0.1.1 #95768

merged 1 commit into from Aug 28, 2020

Conversation

bb2020
Copy link
Member

@bb2020 bb2020 commented Aug 18, 2020 •
edited

Motivation for this change

discrete-scroll is a simple tool to fix broken macOS mouse scroll behavior.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryantm
ryantm reviewed Aug 22, 2020
View reviewed changes
pkgs/os-specific/darwin/discretescroll/default.nix Outdated
## and then launch again

stdenv.mkDerivation rec {
pname = "discretescroll";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the pname not match the repo name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it.

@bb2020 bb2020 changed the title discretescroll: init at 0.1.1 discrete-scroll: init at 0.1.1 Aug 27, 2020
@ryantm ryantm merged commit 3c95f06 into NixOS:master Aug 28, 2020
@bb2020 bb2020 mentioned this pull request Nov 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bb2020 @ryantm