[haskell-updates] haskellPackages.cuda: Mark as unfree because of deps #95771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+2763
to
2766
| - cuda # 2020-08-18 because of dependency nvidia-x11 | ||
| - cublas | ||
| - cufft | ||
| - cusolver |
There was a problem hiding this comment.
I think it makes sense to move it here, especially because things like cublas and cufft are here.
Although it is unfortunate that Hydra (or whatever is responsible for this), isn't smart enough to automatically figure out this shouldn't be built because it has dependencies that aren't free.
| @@ -2760,6 +2760,7 @@ dont-distribute-packages: | |||
| - boolector | |||
| - ccelerate-cuda | |||
There was a problem hiding this comment.
Not related to this PR, but ccelerate-cuda is probably a mispelling of accelerate-cuda.
There is no ccelerate-cuda package on Hackage: https://hackage.haskell.org/package/ccelerate-cuda
There was a problem hiding this comment.
which begs the question. Why don‘t we have any evaluation errors caused by this?
cdepillabout
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes an evaluation error of nixpkgs. Not sure what to test, tbh.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)