Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flashfocus: init at 2.2.2 & pythonPackages.xpybutil: init at 0.0.6 #95757

Merged
merged 2 commits into from Aug 19, 2020
Merged

flashfocus: init at 2.2.2 & pythonPackages.xpybutil: init at 0.0.6 #95757

merged 2 commits into from Aug 19, 2020

Conversation

Artturin
Copy link
Member

Add flashfocus and a not yet packaged dependency

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/xpybutil/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/95757
4 packages built:
flashfocus python27Packages.xpybutil python37Packages.xpybutil python38Packages.xpybutil

@jonringer jonringer merged commit f765171 into NixOS:master Aug 19, 2020
@Artturin
Copy link
Member Author

Thanks!

@Artturin Artturin deleted the add-flashfocus-and-xpybutil branch August 19, 2020 22:20
@Artturin Artturin mentioned this pull request Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Artturin @dotlambda @jonringer