Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.avro: 1.9.2 -> 1.10.0 #95790

Merged
merged 3 commits into from Aug 21, 2020
Merged

pythonPackages.avro: 1.9.2 -> 1.10.0 #95790

merged 3 commits into from Aug 21, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Aug 19, 2020

Motivation for this change

That package is now Python 3 compatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
pythonPackages.avro: 1.9.2 -> 1.10.0
7a4411c 
That package is now Python 3 compatible.
@zimbatm
Copy link
Member Author

zimbatm commented Aug 19, 2020

Result of nixpkgs-review pr 95790 1

4 packages built:
- python27Packages.avro
- python27Packages.confluent-kafka
- python37Packages.avro
- python38Packages.avro

jonringer
jonringer reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a license to the expression

@zimbatm
Copy link
Member Author

zimbatm commented Aug 21, 2020

@jonringer good call, fixed!

jonringer
jonringer approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/95790
4 packages built:
python27Packages.avro python27Packages.confluent-kafka python37Packages.avro python38Packages.avro

@jonringer jonringer merged commit fcd447b into NixOS:master Aug 21, 2020
@zimbatm zimbatm deleted the pythonPackages.avro-1.10.0 branch August 21, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @jonringer