Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve spaCy checks #95762

Merged
merged 2 commits into from Aug 18, 2020
Merged

Improve spaCy checks #95762

merged 2 commits into from Aug 18, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

This PR combines two commits:

  1. Add pythonImportsCheck to the spaCy models, for an extra sanity check (with the absense of upstream model tests).
  2. Add a test to passthru.tests of the spaCy derivation that loads a model and verifies that it outputs the expected annotations. This should be able to catch regressions better than the import check of spaCy.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
python3Packages.spacy_models: use pythonImportCheck
86f1215 
For each model, check whether we can actually import the model after
building.
@danieldk
python3Packages.spacy: add passthru test
ff9e1a0 
I have been using the main example of the spaCy web page for testing
updates of spacy (and its transitive dependencies). Let's convert this
into a proper test to take out manual testing.
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

jonringer
jonringer approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
runs on both python3 interpreters

$ nix build -f ./nixpkgs/ python3Packages.spacy.tests python37Packages.spacy.tests
$

@jonringer jonringer merged commit fb7acac into NixOS:master Aug 18, 2020
@danieldk danieldk deleted the spacy-checks branch August 18, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @jonringer