Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mozwire: init at 0.4.1 #95754

Merged
merged 2 commits into from Aug 19, 2020
Merged

mozwire: init at 0.4.1 #95754

merged 2 commits into from Aug 19, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Aug 18, 2020 •
edited

Motivation for this change

Add mozwire.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben changed the title Add mozwire mozwire: init Aug 18, 2020
@siraben siraben changed the title mozwire: init mozwire: init at 0.4.1 Aug 18, 2020
@siraben
Copy link
Member Author

siraben commented Aug 18, 2020

@GrahamcOfBorg build mozwire

@siraben
Copy link
Member Author

siraben commented Aug 18, 2020

@infinisil looks good to merge?

@siraben
Copy link
Member Author

siraben commented Aug 18, 2020

@GrahamcOfBorg build mozwire

zowoq
zowoq reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the commits:

mozwire: init at 0.4.1
maintainers: add nilsirl

pkgs/tools/networking/mozwire/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/mozwire/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/mozwire/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/mozwire/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/mozwire/default.nix Outdated Show resolved Hide resolved
@siraben
Copy link
Member Author

siraben commented Aug 19, 2020

@GrahamcOfBorg build mozwire

zowoq
zowoq reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the darwin changes into the original commit.

pkgs/tools/networking/mozwire/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/mozwire/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@siraben siraben requested a review from zowoq August 19, 2020 12:13
zowoq
zowoq approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds/runs on darwin.

@zowoq zowoq merged commit 12a9e5f into NixOS:master Aug 19, 2020
@siraben siraben deleted the mozwire branch August 19, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @zowoq @NilsIrl