Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.snap-templates jailbreak #95791

Merged
merged 1 commit into from Aug 19, 2020
Merged

haskellPackages.snap-templates jailbreak #95791

merged 1 commit into from Aug 19, 2020

Conversation

v0d1ch
Copy link
Contributor

@v0d1ch v0d1ch commented Aug 19, 2020

Motivation for this change

stack-templates are marked as broken because of
hashable and template-haskell version mismatch.
I opened up an issue on the upstream repo about it
snapframework/snap-templates#22

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@v0d1ch
haskellPackages.snap-templates jailbreak
7e6ba48 
stack-templates are marked as broken because of
hashable and template-haskell version mismatch.
I opened up an issue on the upstream repo about it
snapframework/snap-templates#22
cdepillabout
cdepillabout approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out and fixing it up!

I've confirmed it builds locally.

@cdepillabout cdepillabout merged commit 2586c5e into NixOS:haskell-updates Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@v0d1ch @cdepillabout @Janik-Haag