Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.3proxy: fix flakiness #95752

Merged
merged 1 commit into from Sep 9, 2020
Merged

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Aug 18, 2020

ZHF: #97479

Motivation for this change

https://hydra.nixos.org/build/125503883

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@misuzu
Copy link
Contributor Author

misuzu commented Aug 18, 2020

@GrahamcOfBorg test _3proxy

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. Otherwise already looking good. Your solution explains the linked test failure.

nixos/tests/3proxy.nix Show resolved Hide resolved
@misuzu
Copy link
Contributor Author

misuzu commented Sep 1, 2020

@GrahamcOfBorg test _3proxy

@ryantm ryantm merged commit a38ffcc into NixOS:master Sep 9, 2020
@misuzu misuzu deleted the 3proxy-test-fix branch April 22, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants