Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.coloredlogs: remove obsolete patch #95759

Merged
merged 1 commit into from Aug 18, 2020
Merged

pythonPackages.coloredlogs: remove obsolete patch #95759

merged 1 commit into from Aug 18, 2020

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Aug 18, 2020

Motivation for this change

coloredlogs build was broken on darwin since it was updated from 10.0 to 14.0.
The patch from xolox/python-coloredlogs#74 has been merged for 11.0, so it does not apply any more.

Please note that the dependency capturer by the same upstream author is also broken on darwin with python38, so this patch can only be tested on python37 at the moment.

Issue for the capturer bug: xolox/python-capturer#10.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.coloredlogs

@tobim tobim force-pushed the python/coloredlogs-nopatch branch from 76a13c9 to f0b7944 Compare August 18, 2020 19:05
@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.coloredlogs

@jonringer
Copy link
Contributor

@marsam @risicle I think you two use darwin, do you mind verifying this builds?

@risicle
Copy link
Contributor

risicle commented Aug 18, 2020

Builds for me macos 10.14.

@jonringer jonringer merged commit e5a097a into NixOS:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobim @jonringer @risicle