Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fet-sh: init at 1.5 #95766

Merged
merged 1 commit into from Aug 19, 2020
Merged

fet-sh: init at 1.5 #95766

merged 1 commit into from Aug 19, 2020

Conversation

elkowar
Copy link
Contributor

@elkowar elkowar commented Aug 18, 2020

Motivation for this change

fet.sh is a simple, pure sh fetch script for Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elkowar elkowar force-pushed the new_package_fetsh branch 2 times, most recently from 34148eb to 82fddc5 Compare August 18, 2020 21:23
@eepykate
Copy link

👍

@elkowar elkowar changed the title fet-sh: init at 1.3 fet-sh: init at 1.5 Aug 19, 2020
ryantm
ryantm requested changes Aug 19, 2020
View reviewed changes
pkgs/tools/misc/fet-sh/default.nix Outdated
meta = with lib; {
description = "A fetch written in posix shell without any external commands (linux only)";
homepage = "https://github.com/6gk/fet.sh";
license = licenses.mit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = licenses.mit;
license = licenses.isc;

pkgs/tools/misc/fet-sh/default.nix

src = fetchFromGitHub {
owner = "6gk";
repo = "fet.sh";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = "fet.sh";
repo = pname;

@ryantm
Copy link
Member

ryantm commented Aug 19, 2020

@GrahamcOfBorg build fet-sh

@eepykate
Copy link

eepykate commented Aug 19, 2020 •
edited

broken; the repo name is not 'fet-sh' like the package name, it's 'fet.sh'

@elkowar
Copy link
Contributor Author

elkowar commented Aug 19, 2020

fixed the package name, i just applied the suggestion without actually thinking if it will work, and then fell victim to nix not actually rebuilding the package if the hash hasn't changed, sorry

@ryantm
Copy link
Member

ryantm commented Aug 19, 2020

Oops, sorry.
@GrahamcOfBorg build fet-sh

@ryantm
Copy link
Member

ryantm commented Aug 19, 2020 •
edited 

$ ./results/fet-sh/bin/fet.sh

 ryantm@home1
    os ~ nixos
    sh ~ bash
    wm ~ GNOME
    up ~ 7d 18:13
   cpu ~ Intel i5-6500
   mem ~ 32843MB
  host ~ Z170X-Gaming 3
  kern ~ 5.4.57
  term ~ .nixpkgs-review

@ryantm
Copy link
Member

ryantm commented Aug 19, 2020

Result of nixpkgs-review pr 95766 1

1 package built:
- fet-sh

@ryantm ryantm merged commit 1ea69f2 into NixOS:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elkowar @eepykate @ryantm