Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attempt at addressing ill-conditioned basis elements. #2679

Merged
merged 3 commits into from
Aug 18, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Aug 18, 2020

Ignore a basis element if it is sufficiently close to the span of the preceding basis elements (cancellation of at least 24 bits). Not only does this yield better accuracy, it doesn't cause such huge tolerance changes between casanova and carpaccio (compare a5d483f and 34e915f)

Contributes to #2400.

// here because our function is real and bounded. But even if the
// norm could be computed but was very small, we would end up with an
// ill-conditioned solution. Geometrically, we are in a situation
// where eₘ/ is very close to the space spanned by the (bₛ), that is,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray /.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Aug 18, 2020
@pleroy pleroy merged commit 62b9d20 into mockingbirdnest:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants