@GrahamcOfBorg build python37Packages.nbxmpp gajim

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

This can be done with:

git reset HEAD~1                    # move fix-up commits into unstaged
git add -- pkgs/                    # move changes into staged
git commit --amend --no-edit        # add changes to previous commit
git push ... ... --force            # modify current PR branch

Squashed using git rebase -i. This can also be achieved when choosing “squash and merge” on the web interface.

in this case, yes, I could squash all of them to one commit. But, there's a CONTRIBUTING.md item in the template to ensure that the process is easier on those who are reviewing

Thanks for reviewing & merging.

The contributing guide does not tell what to do when the reviewer suggests changes through the web interface: is it ok to just push the button “apply suggestion” (in which case it produces a new commit that does not comply with the contributing guide)?

IMHO, leaving the suggested changes in a separate commit — during the reviewing time only — makes the life of the reviewer easier: they know that their suggestion have been applied as-is. If I instead squash at once, they have to review all the changes again: this might be better regarding the quality of the review, but slightly more time-consuming.

generally I do the changes on the branch, then

git add pkgs
git commit --amend --no-edit
git push .. .. --force

It would be nice if they had a Apply suggestion (amend previous) option, I agree