Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-notes: 3.36.2 -> 3.36.3 #95786

Merged
merged 1 commit into from Aug 20, 2020
Merged

gnome-notes: 3.36.2 -> 3.36.3 #95786

merged 1 commit into from Aug 20, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Aug 19, 2020

Motivation for this change

Version bump of gnome-notes (also known as bijiben).
Release news:

Overview of changes in 3.36.3
=============================

* Added Central Kurdish translation (Jwtiyar Nariman)
* Fixed issue in main view paging that was preventing to show more than 48 notes

Translations
* ckb (Jwtiyar Nariman)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Aug 19, 2020
worldofpeace
worldofpeace approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested that it still works.

@worldofpeace worldofpeace merged commit 80d5f73 into NixOS:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasj19 @worldofpeace