New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Remote building for untrusted clients -- contains #3446 #3915
Closed
Ericson2314
wants to merge
62
commits into
NixOS:master
from
obsidiansystems:trustless-remote-builder
Closed
WIP: Remote building for untrusted clients -- contains #3446 #3915
Ericson2314
wants to merge
62
commits into
NixOS:master
from
obsidiansystems:trustless-remote-builder
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to express intermediate values of `hashDerivationModulo` in the following commit.
Use the newly parameterized derivation types to enforce the invariants needed to split these.
…son2314/nix into derivation-template
…/nix into derivation-template-temp
This further continues with the dependency inverstion. Also I just went ahead and exposed `parseDerivation`: it seems like the more proper building block, and not a bad thing to expose if we are trying to be less wedded to drv files on disk anywas.
… into derivation-template
This assumption is broken by CA derivations. Making a PR now to do the breaking daemon change as soon as possible (if it is already too late, we can bump protocol intead).
Path is null when not known statically.
…into just-derivation-template
… into derivation-template
See comment for details.
…314/nix into HEAD
The name is now stored with the derivation itself.
…ems/nix into single-ca-drv-build
…into derivation-template
Since the jsonObject unique ptr is reset to flush the string to make `__json`, all these `!jsonObject` conditions will always be true.
…tems/nix into derivation-template
This is much better than making the caller responsible.
Now covers derivations, with and without input derivations, and all possible `hashModuloDerivation`-motivated template parameters.
See store-api.hh new method description for details.
Ericson2314
force-pushed
the
trustless-remote-builder
branch
from
August 11, 2020 04:50
b085174
to
635a074
Compare
Ah, I'm afraid this approach is dead due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.