Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask_assets: fix tests #95016

Merged
merged 1 commit into from Aug 9, 2020
Merged

pythonPackages.flask_assets: fix tests #95016

merged 1 commit into from Aug 9, 2020

Conversation

cript0nauta
Copy link
Contributor

The changes in pallets/flask@e6178fe introduced in Flask 1.1.2 broke the tests of flask-assets.

This is a bug of flask-assets itself and not of the version in nixpkgs. But I'm doing the same as in #47203 which I think was the best option, since flask-assets seems to be quite unmaintainted.

Motivation for this change

Be able to use flask_assets.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cript0nauta
pythonPackages.flask_assets: fix tests
fa4a758 
The changes in
pallets/flask@e6178fe
introduced in Flask 1.1.2 broke the tests of flask-assets.
@ofborg ofborg bot requested a review from abbradar August 9, 2020 20:53
jonringer
jonringer approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95016 1

4 packages built: - octoprint - python27Packages.flask_assets - python37Packages.flask_assets - python38Packages.flask_assets

@jonringer jonringer merged commit e84a1c5 into NixOS:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cript0nauta @jonringer