Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A first implementation of Кудрявцев projection #2669

Merged
merged 27 commits into from
Aug 10, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Aug 9, 2020

This is far from perfect (see the TODOs) but at least the basic algorithm and all the mechanics to generate Poisson series is in place and passes a test.

A significant contribution to #2400.

// Only indices 0 to m - 1 are used in this array. It contains Bⱼ⁽ᵐ⁾.
std::array<Value, basis_size> B;
for (int j = 0; j < m; ++j) {
Value accumulator;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we call this Σ_αⱼₛ_Qₘₛ (with += and a - below)?
We do that in many places (Σ_Bₗ_m_yˡ in the elliptic integrals, Σj_aʹ_ij_g_jk in an integrator (we should switch to subscripts there someday), etc.), and accumulator is not very informative.

Same for the other accumulators.

This would make it much easier to check the code against the paper.

Copy link
Member Author

@pleroy pleroy Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. (Tofu tofu tofu, tofus tofui tofu, tofua tofua tofua, tofuum tofibus tofibus.)

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Aug 10, 2020
@pleroy pleroy merged commit 596aff2 into mockingbirdnest:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants