Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade: nomad to 0.12.1 #95018

Closed
wants to merge 1 commit into from
Closed

upgrade: nomad to 0.12.1 #95018

wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Aug 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from endocrimes and rushmorem August 9, 2020 21:23
@endocrimes
Copy link
Member

Aaah Sorry I just realised I forgot to finish off #93197 because I've been super busy with life/work

@danieldk
Copy link
Contributor

Thanks for this PR. Closing this, because #93197 is merged.

@danieldk danieldk closed this Aug 13, 2020
@cpcloud cpcloud deleted the upgrade-nomad branch May 11, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes Awaiting requested review from endocrimes

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpcloud @endocrimes @danieldk