Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gfbgraph: 0.2.3 -> 0.2.4 #95048

Merged
merged 1 commit into from Aug 10, 2020
Merged

gfbgraph: 0.2.3 -> 0.2.4 #95048

merged 1 commit into from Aug 10, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Aug 10, 2020

Motivation for this change

Version bump.

=================
LibGFBGraph 0.2.4
=================

The changes include:

- Change Facebook Graph API version to v2.10 by Álvaro Peña.
- Fix memory leaks of GFBGraphNode class by Krzesimir Nowak.
- Support g_autoptr for GFBGraphAlbum, GFBGraphNode, GFBGraphPhoto,
  GFBGraphUser by Leesoo Ahn.
- Fix memory leaks of GFBGraphUser, GFBGraphSimpleAuthorizer,
  GFBGraphAlbum by Leesoo Ahn.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    CC: @jtojnar @worldofpeace @hedning

jtojnar
jtojnar reviewed Aug 10, 2020
View reviewed changes
pkgs/development/libraries/gfbgraph/default.nix Outdated
buildInputs = [ glib gnome-online-accounts ];
propagatedBuildInputs = [ libsoup json-glib librest ];

configureFlags = [ "--enable-introspection" ];

patchPhase = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding patchPhase breaks patches field. Use prePatch or postPatch instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, patchShebangs should handle the shebang substitution.

pkgs/development/libraries/gfbgraph/default.nix Outdated
--replace "which" "${pkgs.which}/bin/which"
'';

autoreconfPhase = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we are not using autoreconfHook so we should just run NOCONFIGURE=1 ./autogen.sh in preConfigure and add autoconf automake libtool to nativeBuildInputs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry totally overseen that. Now it should be covered.

pkgs/development/libraries/gfbgraph/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from jtojnar August 10, 2020 12:46
@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Aug 10, 2020
@ofborg ofborg bot requested a review from jtojnar August 10, 2020 13:33
@jtojnar jtojnar merged commit 3a2ac8a into NixOS:master Aug 10, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 10, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasj19 @jtojnar