Change: Use key names instead of characters in hotkey.cfg #8291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because using .cfg special characters as values is a terrible idea:
=
doesn't work as a single hotkey,
never works at all, it's a hotkey list separator+
and"
would've never worked as well but were strategically avoided even though there are-
and'
\
only work by the miracle of a weird ini parserCOMMA
and"="
only work once before it rewrites config with broken variantsBACKQUOTE
NUM_MINUS
as well as-
even though they're the same character (because they are supposed to be key codes, not characters).So, IMO, the only way out of this mess is to use key names everywhere. Unfortunately, characters will also have to be kept, at least for a while, to convert old configs.