Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applet.interface.jtag_probe: convert to nmigen. #197

Merged
merged 1 commit into from Oct 3, 2020
Merged

applet.interface.jtag_probe: convert to nmigen. #197

merged 1 commit into from Oct 3, 2020

Conversation

miek
Copy link
Contributor

@miek miek commented Aug 9, 2020

I've done basic testing on a revC1, but please let me know if I should run any other checks or make any changes

$ glasgow run jtag-probe -V3.3 --port A --pin-tck 1 --pin-tms 2 --pin-tdi 4 --pin-tdo 3 scan            
I: g.device.hardware: building bitstream ID 7b2f28d67ee5ecae0d845d2b67c02856
I: g.cli: running handler for applet 'jtag-probe'
I: g.applet.interface.jtag_probe: port(s) A voltage set to 3.3 V
I: g.applet.interface.jtag_probe: shifted 32-bit DR=<11000010000010001000100010000010>
I: g.applet.interface.jtag_probe: shifted 8-bit IR=<10100000>
I: g.applet.interface.jtag_probe: DR segmentation discovered 1 devices
I: g.applet.interface.jtag_probe: TAP #0: IR[8] IDCODE=0x41111043
I: g.applet.interface.jtag_probe: manufacturer=0x021 (Lattice Semi.) part=0x1111 version=0x4

ref #150

whitequark
whitequark requested changes Aug 9, 2020
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor stylistic changes.

software/glasgow/applet/interface/jtag_probe/__init__.py Outdated Show resolved Hide resolved
software/glasgow/applet/interface/jtag_probe/__init__.py Outdated Show resolved Hide resolved
software/glasgow/applet/interface/jtag_probe/__init__.py Outdated Show resolved Hide resolved
software/glasgow/applet/interface/jtag_probe/__init__.py Outdated Show resolved Hide resolved
@whitequark whitequark merged commit bcf655f into GlasgowEmbedded:master Oct 3, 2020
@whitequark
Copy link
Member

Sorry, not sure how this lingered so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miek @whitequark