Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undervolt: expose power limits as Nixopts #95011

Merged
merged 1 commit into from Oct 30, 2020
Merged

undervolt: expose power limits as Nixopts #95011

merged 1 commit into from Oct 30, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Aug 9, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu Atemu requested a review from pbogdan August 9, 2020 15:43
@Atemu
undervolt: expose power limits as Nixopts
eb4e675 
We no longer escape the flags because the power limit flags want two arguments
If we escaped them, we'd only get one argument with an escaped space in it.

Undervolt's flags don't have anything in them that would need to be escaped, so
that shouldn't break anything
@Atemu
Copy link
Member Author

Atemu commented Aug 22, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 22, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@Atemu Atemu requested a review from Lassulus September 5, 2020 20:58
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 21, 2020

@glittershark please review.

glittershark
glittershark reviewed Oct 22, 2020
View reviewed changes
nixos/modules/services/hardware/undervolt.nix
Both limit and window must be set.
'';
};
p2.window = mkOption {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a thought, but we might be able to use a submodule type to deduplicate the window and limit type definitions. But that might be overly abstracted, so I'll leave it up to you / other reviewers

@glittershark
Copy link
Member

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau October 22, 2020 22:31
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 26, 2020

Reminder: Please review!

Reminder: This Pull Request is awaiting merger. If you are the assigned reviewer with commit permission, please have a look. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

timokau
timokau approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glittershark and @pbogdan for the reviews.

@timokau timokau merged commit 83f48e8 into NixOS:master Oct 30, 2020
@Atemu
Copy link
Member Author

Atemu commented Oct 30, 2020

Thank you!

Should we backport this to 20.09? It already has the undervolt update which allows for this feature.

@timokau
Copy link
Member

timokau commented Oct 30, 2020

Yes, I think that would be fine, since its purely a feature-addition without risk of breakge. Its not my decision though. I think it would be best to open a backport PR and ping one of the release managers.

@Atemu Atemu mentioned this pull request Oct 31, 2020
Merged
10 tasks
@Atemu Atemu deleted the undervolt-pl branch October 31, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbogdan pbogdan pbogdan approved these changes

@glittershark glittershark glittershark approved these changes

@timokau timokau timokau approved these changes

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Atemu @glittershark @timokau @pbogdan